Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST ONLY] test fixes for 2.11 server changes #798

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

levb
Copy link
Collaborator

@levb levb commented Sep 11, 2024

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.67%. Comparing base (1553d4a) to head (e727531).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   68.71%   70.67%   +1.96%     
==========================================
  Files          39       47       +8     
  Lines       15207    15146      -61     
  Branches     3143     3096      -47     
==========================================
+ Hits        10449    10705     +256     
+ Misses       1700     1455     -245     
+ Partials     3058     2986      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb merged commit 2d74e02 into main Sep 11, 2024
30 checks passed
@levb levb deleted the lev-fix-tests-for-server-changes branch September 11, 2024 15:56
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
levb added a commit that referenced this pull request Oct 1, 2024
* [TEST ONLY] server adds stream metadata now

* [TEST ONLY] protect JetStreamSubscribeFlowControl against rate limiting
@levb levb removed the cherry-pick label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants