Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Support %-encoded username/password in server URLs #765

Merged
merged 8 commits into from
Jun 13, 2024
Merged

Conversation

levb
Copy link
Collaborator

@levb levb commented Jun 13, 2024

Fixes #762

@levb levb requested a review from mtmk June 13, 2024 06:32
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (1cb8d8c) to head (a1533fc).
Report is 1 commits behind head on main.

Files Patch % Lines
src/url.c 76.19% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
+ Coverage   68.68%   68.71%   +0.03%     
==========================================
  Files          39       39              
  Lines       15186    15207      +21     
  Branches     3139     3143       +4     
==========================================
+ Hits        10431    10450      +19     
+ Misses       1702     1699       -3     
- Partials     3053     3058       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/test.c Show resolved Hide resolved
Base automatically changed from lev-fix-JetStreamSubscribeIdleHeartbeat to main June 13, 2024 15:25
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb merged commit 8505264 into main Jun 13, 2024
15 checks passed
@levb levb deleted the lev-url-encode branch June 13, 2024 17:03
github-actions bot pushed a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support URL (%-) encoding in server URL strings
2 participants