Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] JetStream: natsSubscription_Fetch() not honoring timeout #634

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Feb 2, 2023

In some conditions, it could be possible for natsSubscription_Fetch() to return with a NATS_TIMEOUT error after said timeout elpased, but the next call would return almost immediately with a NATS_TIMEOUT again, but not after waiting for the specified timeout.

Resolves #631

Signed-off-by: Ivan Kozlovic [email protected]

In some conditions, it could be possible for natsSubscription_Fetch()
to return with a NATS_TIMEOUT error after said timeout elpased, but
the next call would return almost immediately with a NATS_TIMEOUT
again, but not after waiting for the specified timeout.

Resolves #631

Signed-off-by: Ivan Kozlovic <[email protected]>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 3741f67 into main Feb 2, 2023
@kozlovic kozlovic deleted the fix_631 branch February 2, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

natsSubscription_Fetch not respecting timeout
2 participants