Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Use of <ctype.h> methods if char is signed #627

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

sebhub
Copy link
Contributor

@sebhub sebhub commented Jan 24, 2023

According to the C standard, the argument to the <ctype.h> methods shall be representable as an unsigned char or shall equal the value of the macro EOF. It is implementation-defined if the char type is signed or unsigned.

Signed-off-by: Sebastian Huber [email protected]

According to the C standard, the argument to the <ctype.h> methods
shall be representable as an unsigned char or shall equal the value of
the macro EOF.  It is implementation-defined if the char type is signed
or unsigned.

Signed-off-by: Sebastian Huber <[email protected]>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@kozlovic kozlovic changed the title Fix use of <ctype.h> methods if char is signed [FIXED] Use of <ctype.h> methods if char is signed Jan 24, 2023
@kozlovic kozlovic merged commit e1adfd5 into nats-io:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants