[FIXED] JetStream: Ordered consumer issues #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
requested review from
aricart and
ColinSullivan1
and removed request for
aricart
kozlovic
commented
Oct 5, 2022
| @@ -1538,6 +1538,7 @@ jsSub_processSequenceMismatch(natsSubscription *sub, natsMsg *msg, bool *sm) | |||
| jsSub *jsi = sub->jsi; | |||
| const char *str = NULL; | |||
| int64_t val = 0; | |||
| struct mismatch *m = &jsi->mismatch; | |||
There was a problem hiding this comment.
No, this is a pointer to an internal structure (take the address of). I could have name those fields say "mldseq", etc.. but decided to make them part of a struct.
- It would reset when receiving hearbeats due to a bug on how I was checking for sequence mismatch (overriding ldseq/sseq/etc..) - On reset, the consumer configuration would not be the same than the original. That was because I was not making a copy of the original consumer config. Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic
force-pushed
the
fix_ordered_cons
branch
from
8ac1b6b
to
1232a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivan Kozlovic [email protected]