[FIXED] JetStream: jsConsumerConfig.Name was not unmarshal'ed
#599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new configuration `Name` in `jsConsumerConfig` could be set when calling `js_AddConsumer`, but when getting the `jsConsumerInfo` response (from that call or any `js_GetConsumerInfo`, the `Name` was present in `jsConsumerInfo`, but was not in the `Config` field (a `jsConsumerConfig`). Although I am not sure this is needed, making sure that we unmarshal properly. Signed-off-by: Ivan Kozlovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new configuration
NameinjsConsumerConfigcould be set when callingjs_AddConsumer, but when getting thejsConsumerInforesponse (from that call or anyjs_GetConsumerInfo, theNamewas present injsConsumerInfo, but was not in theConfigfield (ajsConsumerConfig). Although I am not sure this is needed, making sure that we unmarshal properly.Signed-off-by: Ivan Kozlovic [email protected]