[FIXED] JetStream: Ordered consumers may not be reset in some cases #596
+163
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the recreation of the ordered consumer were to fail, the library would invalidate the subscription and not try again. This PR also changes the ordered consumer to use memory storage and replicas of 1. It also ensures that the ordered consumer is reset on missed heartbeats. Signed-off-by: Ivan Kozlovic <[email protected]>
11 tasks
kozlovic
added a commit
that referenced
this pull request
Oct 4, 2022
- Was not setting to MemoryStorage and Replicas of 1 on recreate - Added test that checks for MemoryStorage after a reset - Improved error reporting when failing to recreate the consumer Related to #596 Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic
added a commit
that referenced
this pull request
Oct 4, 2022
- Was not setting to MemoryStorage and Replicas of 1 on recreate - Added test that checks for MemoryStorage after a reset - Improved error reporting when failing to recreate the consumer Related to #596 Signed-off-by: Ivan Kozlovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the recreation of the ordered consumer were to fail, the library would invalidate the subscription and not try again.
This PR also changes the ordered consumer to use memory storage and replicas of 1. It also ensures that the ordered consumer is reset on missed heartbeats.
Signed-off-by: Ivan Kozlovic [email protected]