PR feedback

nats-io · Nov 5, 2024 · a15d5a8 · a15d5a8
1 parent 9bc5e7f
commit a15d5a8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/micro.c b/src/micro.c
@@ -276,15 +276,16 @@ _attach_service_to_connection(natsConnection *nc, microService *service)
             else
                 nc->services = tmp;
         }
-    }
 
-    if (s == NATS_OK)
-    {
-        service->refs++; // no lock needed, called from the constructor
-        nc->services[nc->numServices] = service;
-        nc->numServices++;
+        if (s == NATS_OK)
+        {
+            service->refs++; // no lock needed, called from the constructor
+            nc->services[nc->numServices] = service;
+            nc->numServices++;
+        }
+        natsMutex_Unlock(nc->servicesMu);
     }
-    natsMutex_Unlock(nc->servicesMu);
+
     natsConn_Unlock(nc);
 
     return micro_ErrorFromStatus(s);

diff --git a/src/micro_endpoint.c b/src/micro_endpoint.c
@@ -279,7 +279,7 @@ micro_clone_endpoint_config(microEndpointConfig **out, microEndpointConfig *cfg)
     microEndpointConfig *new_cfg = NULL;
 
     if (out == NULL)
-        return microError_Wrapf(err, "failed to clone endpoint config: '%s'", cfg->Name);
+        return microError_Wrapf(micro_ErrorInvalidArg, "failed to clone endpoint config: '%s'", cfg->Name);
 
     if (cfg == NULL)
     {
@@ -303,7 +303,6 @@ micro_clone_endpoint_config(microEndpointConfig **out, microEndpointConfig *cfg)
     {
         micro_free_cloned_endpoint_config(new_cfg);
         return microError_Wrapf(err, "failed to clone endpoint config: '%s'", cfg->Name);
-        return err;
     }
 
     *out = new_cfg;