Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cancelMirrorConsumer call inside the locked section in retryMirrorConsumer #5369

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

jnmoyne
Copy link
Contributor

@jnmoyne jnmoyne commented Apr 30, 2024

Move cancelMirrorConsumer call inside the locked section in retryMirrorConsumer

@jnmoyne jnmoyne requested a review from a team as a code owner April 30, 2024 16:39
@ripienaar
Copy link
Contributor

Signed-off-by: Your Name [[email protected]](mailto:[email protected])

:)

@jnmoyne
Copy link
Contributor Author

jnmoyne commented Apr 30, 2024

Edited :)

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jnmoyne referenced this pull request Apr 30, 2024
- Resets the stalling detection timestamp upon re-creating the consumer
- Adjust the idle heart beat for source/mirror consumers from 1s to 5s

---------

Signed-off-by: Jean-Noël Moyne <[email protected]>
@derekcollison derekcollison merged commit 5e5bfc1 into main Apr 30, 2024
4 checks passed
@derekcollison derekcollison deleted the jnm/30Apr24 branch April 30, 2024 17:39
wallyqs pushed a commit that referenced this pull request May 1, 2024
…orConsumer (#5369)

Move cancelMirrorConsumer call inside the locked section in
retryMirrorConsumer

Signed-off-by: Jean-Noël Moyne <[email protected]>
wallyqs pushed a commit that referenced this pull request May 1, 2024
…orConsumer (#5369)

Move cancelMirrorConsumer call inside the locked section in
retryMirrorConsumer

Signed-off-by: Jean-Noël Moyne <[email protected]>
wallyqs added a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants