-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHANGE] Tags are now case-sensitive #225
Conversation
…ersions of the library lowercased all tags. Now tags such as "A" and "a" are different.
this enables use of tags macros for more complex conditions where mixed case values are possible see nats-io/nats-server#5681 |
Pull Request Test Coverage Report for Build 10837995316Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, question on the other PR about impact
@ripienaar as discussed, changing the client (nsc) to have a flag that verifies the intention to be case sensitive - if input is detected on nsc that doesn't match lowercased version of the value, nsc will reject the edit and request for the case sensitive flag to be provided. |
* Revert "[CHANGE] Tags are now case-sensitive (#225)" This reverts commit de1f16b. * retract 2.7.0 Signed-off-by: Alberto Ricart <[email protected]> --------- Signed-off-by: Alberto Ricart <[email protected]>
Previous versions of the library lowercased all tags. Now tags such as "A" and "a" are different.