Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGE] Tags are now case-sensitive #225

Merged
merged 2 commits into from
Sep 17, 2024
Merged

[CHANGE] Tags are now case-sensitive #225

merged 2 commits into from
Sep 17, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Sep 12, 2024

Previous versions of the library lowercased all tags. Now tags such as "A" and "a" are different.

…ersions of the library lowercased all tags. Now tags such as "A" and "a" are different.
@aricart
Copy link
Member Author

aricart commented Sep 12, 2024

this enables use of tags macros for more complex conditions where mixed case values are possible see nats-io/nats-server#5681

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10837995316

Details

  • 30 of 43 (69.77%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 80.994%

Changes Missing Coverage Covered Lines Changed/Added Lines %
v2/types.go 30 43 69.77%
Files with Coverage Reduction New Missed Lines %
v2/types.go 1 86.08%
Totals Coverage Status
Change from base Build 10801439726: -0.1%
Covered Lines: 2753
Relevant Lines: 3399

💛 - Coveralls

@aricart aricart changed the title [CHANGE] Tags (--tag and --rm-tag) are now case-sensitive [CHANGE] Tags are now case-sensitive Sep 12, 2024
Copy link

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, question on the other PR about impact

@aricart
Copy link
Member Author

aricart commented Sep 17, 2024

@ripienaar as discussed, changing the client (nsc) to have a flag that verifies the intention to be case sensitive - if input is detected on nsc that doesn't match lowercased version of the value, nsc will reject the edit and request for the case sensitive flag to be provided.

@aricart aricart merged commit de1f16b into main Sep 17, 2024
6 of 8 checks passed
aricart added a commit that referenced this pull request Oct 9, 2024
aricart added a commit that referenced this pull request Oct 9, 2024
* Revert "[CHANGE] Tags are now case-sensitive (#225)"

This reverts commit de1f16b.

* retract 2.7.0

Signed-off-by: Alberto Ricart <[email protected]>

---------

Signed-off-by: Alberto Ricart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants