Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RAII instead of manual memory management #24

Open
drubinstein opened this issue Apr 2, 2019 · 2 comments
Open

Use RAII instead of manual memory management #24

drubinstein opened this issue Apr 2, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@drubinstein
Copy link
Contributor

Remove manual memory management and move to RAII when possible

Examples:
_data in ResponseImplementation. malloc and free should become std::vector<uint8_t>.
https://github.com/spotify/NFHTTP/blob/63210526176f2d7ce33a65ffe54c0fa31ac55632/source/ResponseImplementation.cpp#L44
https://github.com/spotify/NFHTTP/blob/63210526176f2d7ce33a65ffe54c0fa31ac55632/source/ResponseImplementation.cpp#L57
https://github.com/spotify/NFHTTP/blob/63210526176f2d7ce33a65ffe54c0fa31ac55632/source/ResponseImplementation.cpp#L77
@drubinstein drubinstein mentioned this issue Apr 2, 2019
Closed
@elfring elfring mentioned this issue Apr 2, 2019
Closed
@kebbbnnn
Copy link
Contributor

kebbbnnn commented Apr 6, 2019

can I try do this? 😁

@drubinstein
Copy link
Contributor Author

drubinstein commented Apr 6, 2019 •
edited
Loading

Consider yourself assigned.

I can't officially assign you cause you're not in the org. But you're still assigned.

@drubinstein drubinstein added the good first issue Good for newcomers label Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drubinstein @kebbbnnn