Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: translations - the default language should be set based on OS / browser language preferences #578

Closed
SuperITMan opened this issue Jul 31, 2018 · 0 comments · Fixed by #657
Closed

core: translations - the default language should be set based on OS / browser language preferences #578

SuperITMan opened this issue Jul 31, 2018 · 0 comments · Fixed by #657
Milestone
10.0.0-alpha.5

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Currently, the default language in Showcase is dutch.

Expected behavior

The default language should be based on the OS / browser language preferences
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0.0-alpha.5
Development

Successfully merging a pull request may close this issue.

feat(stark-core): use the browser language as the default language
3 participants
@christophercr @SuperITMan @RobbyDeLaet