Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: stark-ui - unresolved dependencies detected by Rollup #532

Closed
christophercr opened this issue Jul 18, 2018 · 0 comments · Fixed by #533
Closed

build: stark-ui - unresolved dependencies detected by Rollup #532

christophercr opened this issue Jul 18, 2018 · 0 comments · Fixed by #533

Comments

@christophercr
Copy link
Collaborator

christophercr commented Jul 18, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Rollup displays some warnings due to circular dependencies while building the package:

(!) Unresolved dependencies
https://github.com/rollup/rollup/wiki/Troubleshooting#treating-module-as-external-dependency
@angular/material/dialog (imported by dist\packages\stark-ui\esm5\src\modules\table\components\dialogs\multisort.component.js, dist\packages\stark-ui\esm5\src\modules\table\table.module.js, dist\packages\stark-ui\esm5\src\modules\table\components\table.component.js)
@angular/common (imported by dist\packages\stark-ui\esm5\src\modules\slider\slider.module.js, dist\packages\stark-ui\esm5\src\modules\pretty-print\pretty-print.module.js)
@angular/forms (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js)
@angular/platform-browser/animations (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js)
@angular/material/button (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js)
@angular/material/checkbox (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js)
@angular/material/icon (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js)
@angular/material/input (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js)
@angular/material/list (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js)
@angular/material/menu (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js)
@angular/material/paginator (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js, dist\packages\stark-ui\esm5\src\modules\table\components\table.component.js)
@angular/material/select (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js)
@angular/material/sort (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js)
@angular/material/table (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js, dist\packages\stark-ui\esm5\src\modules\table\components\column.component.js, dist\packages\stark-ui\esm5\src\modules\table\components\table.component.js)
@angular/material/tooltip (imported by dist\packages\stark-ui\esm5\src\modules\table\table.module.js)
nouislider (imported by dist\packages\stark-ui\esm5\src\modules\slider\components\slider.component.js)
prismjs (imported by dist\packages\stark-ui\esm5\src\modules\pretty-print\components\pretty-print.component.js)
prismjs/components/prism-typescript.min.js (imported by dist\packages\stark-ui\esm5\src\modules\pretty-print\components\pretty-print.component.js)
prismjs/components/prism-sql.min.js (imported by dist\packages\stark-ui\esm5\src\modules\pretty-print\components\pretty-print.component.js)
prismjs/components/prism-json.min.js (imported by dist\packages\stark-ui\esm5\src\modules\pretty-print\components\pretty-print.component.js)
prismjs/components/prism-scss.min.js (imported by dist\packages\stark-ui\esm5\src\modules\pretty-print\components\pretty-print.component.js)
@angular/cdk/collections (imported by dist\packages\stark-ui\esm5\src\modules\table\components\table.component.js)

Apart from tslib which is a known dependency that should not be resolved:

tslib (imported by dist\packages\stark-ui\esm5\src\modules\slider\components\slider.component.js, dist\packages\stark-ui\esm5\src\modules\table\components\table.component.js)
tslib (imported by dist\packages\stark-ui\src\modules\table\components\table.component.js, dist\packages\stark-ui\src\modules\slider\components\slider.component.js)

Expected behavior

Rollup should be able to resolve all dependencies while building the stark-ui package.

Minimal reproduction of the problem with instructions

Run npm run build:stark-ui -- --trace to see the full log.

What is the motivation / use case for changing the behavior?

A working building process with no errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant