Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: theming - theme SCSS import #456

Closed
catlabs opened this issue Jun 22, 2018 · 0 comments · Fixed by #473
Closed

ui: theming - theme SCSS import #456

catlabs opened this issue Jun 22, 2018 · 0 comments · Fixed by #473

Comments

@catlabs
Copy link
Contributor

catlabs commented Jun 22, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Expected behavior

Right now the end user can only import
@import "~@nationalbankbelgium/stark-ui/assets/themes/theming";
Which load all the scss theme files.

We only need to import the scss theme files of the imported components.

@catlabs catlabs added this to the 10.0.0-alpha.3 milestone Jun 22, 2018
catlabs added a commit to catlabs/stark that referenced this issue Jun 29, 2018
ISSUES CLOSED: NationalBankBelgium#456, NationalBankBelgium#472

# Conflicts:
#	showcase/package.json
#	starter/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants