Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No default connection string if connectManually #89

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

rigwild
Copy link
Contributor

@rigwild rigwild commented May 6, 2019

This adds the abillity to provide null instead of a default connection string when connectManually option is turned on.

Vue.use(VueNativeSock, null, {
  store,
  connectManually: true
})

I got this use case for an app which can connect arbitrarily to the user's selected host.
Temporary workaround : set ws://example.com as a default connection string and use :

Vue.prototype.$socket.$connect('ws://your_host.com')

to connect to any WebSocket server. This workaround is not ideal as you don't own the example.com domain.

@weglov weglov merged commit 9e52734 into nathantsoi:master Aug 2, 2021
@rigwild rigwild deleted the patch-1 branch May 5, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants