Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try adding JET.jl to the tests #258

Closed
nathanaelbosch opened this issue Oct 27, 2023 · 1 comment · Fixed by #261
Closed

Try adding JET.jl to the tests #258

nathanaelbosch opened this issue Oct 27, 2023 · 1 comment · Fixed by #261
Labels
help wanted Extra attention is needed

Comments

@nathanaelbosch
Copy link
Owner

JET is now part of PkgTemplates (JuliaCI/PkgTemplates.jl#432), so maybe their default JET test should be in our test suite too:

JET.test_package(ProbNumDiffEq; target_defined_modules = true)
@nathanaelbosch nathanaelbosch changed the title Try adding Jet.jl to the tests Try adding JET.jl to the tests Oct 30, 2023
@nathanaelbosch
Copy link
Owner Author

Just tried this. Unfortunately I get one error that I don't know how to fix:

julia> JET.test_package(ProbNumDiffEq; target_defined_modules=true)
JET-test failed at /home/nbosch/.julia/packages/JET/V1CGm/src/JET.jl:1185
  Expression: (JET.report_package)(ProbNumDiffEq; toplevel_logger = nothing, target_defined_modules = true)
  ═════ 1 possible error found ═════
  ┌ apply_recipe(plotattributes::AbstractDict{Symbol, Any}, sol::ProbNumDiffEq.AbstractProbODESolution) @ ProbNumDiffEq /home/nbosch/.julia/packages/RecipesBase/BRe07/src/RecipesBase.jl:298
  │ no matching method found `is_key_supported(::Symbol)`: (RecipesBase).is_key_supported::typeof(RecipesBase.is_key_supported)(:idxs)
  └────────────────────

ERROR: There was an error during testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant