You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The calls to matchLeft() and matchRight() are incorrect; they need to pass the parent and index down. As in, matchLeft(node, parent, i) and matchRight(node, parent, i). Otherwise, when using multiple combinators, the parent is never passed down, and will always be undefined, so lines 195 and 202 will always trigger, and return false.
Ah good catch, thank you for raising that! If you're up for a PR that would be very helpful, otherwise it might take me a bit to dive back into cleaning up the issues here.
ultrahtml/src/selector.ts
Line 190 in 93a1273
The calls to matchLeft() and matchRight() are incorrect; they need to pass the parent and index down. As in, matchLeft(node, parent, i) and matchRight(node, parent, i). Otherwise, when using multiple combinators, the parent is never passed down, and will always be undefined, so lines 195 and 202 will always trigger, and return false.
The text was updated successfully, but these errors were encountered: