Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize doesn't block or drop children of blocked node #62

Open
oliverlynch opened this issue Sep 20, 2023 · 0 comments
Open

Sanitize doesn't block or drop children of blocked node #62

oliverlynch opened this issue Sep 20, 2023 · 0 comments

Comments

@oliverlynch
Copy link

Hello! Sanitize doesn't behave how I would expect when dealing with child elements of blocked nodes. The root node is blocked but the children are not removed even if they match a blocked or dropped element.

Blocked Elements

{ blockElements: ["body", "h1"] }
<body><h1>Hello World!</h1><p>Testing</p></body>

Expected result:
<p>Testing</p>

Received result:
<h1>Hello world!</h1><p>Testing</p>

Dropped Elements

{ blockElements: ["body"] } (Script dropped automatically)
<body><script>console.log("pwnd")</script><p>Testing</p></body>

Expected result:
<p>Testing</p>

Received result:
<script>console.log("pwnd")</script><p>Testing</p>

Here are the test cases I used to confirm this behavior:
sanitize.test.ts

it("children of blocked elements can be blocked", async () => {
    const input = `<body><h1>Hello world!</h1></body>`;
    const output = await transform(input, [
      sanitize({ blockElements: ["body", "h1"] }),
    ]);
    expect(output).toEqual("");
});
it("children of blocked elements can be dropped", async () => {
    const input = `<body><script>console.log("pwnd")</script></body>`;
    const output = await transform(input, [
      sanitize({ blockElements: ["body"] }),
    ]);
    expect(output).toEqual("");
});
it("children of blocked elements can drop attributes", async () => {
    const input = `<body><h1 no="way">Hello world!</h1></body>`;
    const output = await transform(input, [
      sanitize({ blockElements: ["body"], dropAttributes: { no: ["h1"] } }),
    ]);
    expect(output).toEqual("<h1>Hello world!</h1>");
});

The final of the three tests passes correctly, but it may be a useful test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliverlynch