Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pager for help text option only works on top-level help #221

Closed
scott-vincent opened this issue Mar 24, 2019 · 1 comment · Fixed by #237
Closed

Use Pager for help text option only works on top-level help #221

scott-vincent opened this issue Mar 24, 2019 · 1 comment · Fixed by #237
Labels
good first issue This seems like a good issue if you're a new contributor. help wanted We would be willing to take a well-written PR to help fix this.

Comments

@scott-vincent
Copy link

scott-vincent commented Mar 24, 2019 •
edited
Loading

Describe the bug
The recent change to stop using the pager when displaying help text only works for top-level help. If I do, e.g. "command subCommand -h" the pager is still used.

To Reproduce
Steps to reproduce the behavior:

  1. Using this version of the library '2.3.3'
  2. Change was added here: #216
  3. With these arguments 'command subCommand -h'
  4. Pager is still being used when app.UserPagerForHelpText = false

Expected behavior
The pager should never be used if UsePagerForHelpText is false.
@natemcmaster natemcmaster added good first issue This seems like a good issue if you're a new contributor. help wanted We would be willing to take a well-written PR to help fix this. labels Apr 9, 2019
@natemcmaster
Copy link
Owner

I would accept a PR to fix this. The workaround is to set UsePagerForHelpText=false on subcommands as well.

@vpkopylov vpkopylov mentioned this issue May 23, 2019
Merged
@natemcmaster natemcmaster mentioned this issue Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This seems like a good issue if you're a new contributor. help wanted We would be willing to take a well-written PR to help fix this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UsePagerForHelpText property is inherited vpkopylov/CommandLineUtils
2 participants
@natemcmaster @scott-vincent