Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workbench desktop icon is cropped/squashed #1236

Closed
davemfish opened this issue Mar 6, 2023 · 4 comments
Closed

Workbench desktop icon is cropped/squashed #1236

davemfish opened this issue Mar 6, 2023 · 4 comments
Assignees
@emlys
Labels
bug Something isn't working workbench For issues relating to the workbench front-end of invest
Milestone
3.13.0

Comments

@davemfish
Copy link
Contributor

After replacing the interim icon with our standard InVEST.ico icon, the icon - as it appears in the Windows tray, or in the upper-left corner of the Workbench window - is not even close to square.
@davemfish davemfish added this to the 3.13.0 milestone Mar 6, 2023
@davemfish davemfish self-assigned this Mar 6, 2023
@davemfish davemfish added bug Something isn't working workbench For issues relating to the workbench front-end of invest labels Mar 6, 2023
@davemfish davemfish removed their assignment Mar 7, 2023
@emlys emlys self-assigned this Mar 7, 2023
@emlys
Copy link
Member

emlys commented Mar 7, 2023

@davemfish I'm not sure if I'm seeing the same thing on mac - here's what it looks like for me.
image
It's not square, but it's proportional to the original image - it just seems to be ignoring the blank space that pads the top and bottom of the image to make it square. Is this what you're seeing, or is it more distorted?

@phargogh
Copy link
Member

phargogh commented Mar 7, 2023

Here's what I'm seeing on Windows 11 Pro 22H2:

In the Windows tray things look pretty normal:
Screenshot 2023-03-07 145457

And in the window corner, the image definitely does not:
Screenshot 2023-03-07 145521

@emlys
Copy link
Member

emlys commented Mar 7, 2023

Possibly related: electron-userland/electron-builder#2128

@emlys emlys mentioned this issue Mar 8, 2023
Merged
3 tasks
@emlys
Copy link
Member

emlys commented Mar 9, 2023

Fixed in #1240

@emlys emlys closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emlys emlys

Labels
bug Something isn't working workbench For issues relating to the workbench front-end of invest
Projects
None yet
Milestone
3.13.0
Development

No branches or pull requests
3 participants
@davemfish @phargogh @emlys