osal Integration candidate: Caelum-rc4+dev41 #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct a few syntactical items that are valid C99 but not valid for C++03. This includes use of the designated initializer, compound literals, variadic macros, and a trailing comma in enum declarations. Note this only matters for public API headers, as some users may need to include these directly from a c++ file. For normal C source files, these are all compiled as C99 and thus the syntax is fine.
Adds a new build and test workflow that includes an API validation with both C and C++ compilers. This should catch any cases where syntactical elements that work in C but do not work in C++ appear in the headers.
Fix #1365, fixup API headers for C++
Fix #1370, workflow to validate OSAL API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
osapi-clock.hheader breaks C++ compilation unit. #1365Testing performed
cFS Bundle Checks
osal Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 20.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey