Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppcheck a vxworks build #146

Closed
skliper opened this issue Sep 30, 2019 · 4 comments
Closed

cppcheck a vxworks build #146

skliper opened this issue Sep 30, 2019 · 4 comments

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

I need to go through the somewhat manual (for now) process
of grinding out some cppcheck results for "development" osal
on our lab machine that has VxWorks capability.

@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 123. Created by glimes on 2015-12-01T12:22:49, last modified: 2019-08-14T14:11:46

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-12-31 10:29:40:

BioSentinal is now synchronized with a recent "development" collection
from the CFS trees, and is building for VxWorks on SPARC and PowerPC, as
well as the default pc-linux config, using scripts similar to the CFS
Community Bamboo Plan.

Currently, CPPCHECK results over there are looking similar. Will set aside
some time to do a side-by-side comparison.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2016-04-08 13:00:11:

We have done a complete cppcheck of the CFS build,
see [cfs_cfe:119 CFE Ticket 119] for full results
of a Sparc VxWorks build.

The only item actually present in the OSAL tree was:
{{{
osal/src/os/vxworks6/osapi.c:3046: style: Unused variable: ret
Declaration should be controlled by the same #ifdef that controls
whether the code that needs it is present.
}}}
This is pretty trivial -- it should probably be swept up
and fixed the next time someone pokes the vxworks6 osapi.c
but is not really worth of triggering a change on its own.

@skliper skliper removed their assignment Sep 30, 2019
@skliper skliper added this to the 5.1.0 milestone Oct 22, 2019
@skliper
Copy link
Contributor Author

skliper commented Jan 2, 2020

cppcheck is now enforced on all flight code per #314

@skliper skliper closed this as completed Jan 2, 2020
@skliper skliper removed this from the 5.1.0 milestone Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant