Fix #723, CFE_EVS_Register const correct and report truncation #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
skliper
force-pushed
the
fix723-filter_truncation
branch
from
4865c3c to
b50cd5b
Compare
astrogeco
added
CCB:2021-01-27
and removed
CCB:Ready
|
CCB:2021-01-27 CHANGE REQUESTED
|
|
@jphickey Looked at this again... it's a void to support different filter types. Casts to the specifically selected filter type (we only support binary filters now), but there for future supported if needed. |
|
OK sounds good ... as long as there's a reason! |
jphickey
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #723 - Filters pointer now const in API and truncation is reported in the system log
Testing performed
Built and ran unit tests (already cover the truncation case), verified new system log message
Expected behavior changes
Reports truncation when registering filters with CFE_EVS_Register
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC