Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #680, Remove table service exclusion logic #1132

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 26, 2021

Describe the contribution
Fix #680 - This removes the final remnants of the table service exclusion logic and documentation.

Testing performed
Build and run unit tests, passed.

Expected behavior changes
No affect to default behavior. EXCLUDE_CFE_TBL no longer used, if define table services will still be started.

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
#972 will transition table service to a module that can be customized or implemented differently if desired.

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 26, 2021
@skliper skliper added this to the 7.0.0 milestone Jan 26, 2021
@skliper skliper force-pushed the fix680-conditional_tbl branch from 5120aa2 to 8257c1e Compare January 27, 2021 14:33
@astrogeco astrogeco added CCB:2021-01-27 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 27, 2021
@astrogeco
Copy link
Contributor

CCB:2021-01-27 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate February 3, 2021 22:39
@astrogeco
Copy link
Contributor

@skliper, #680 references #660 which we seem to have abandoned. Should we revisit and finish #660 which seems to be mostly complete?

@skliper
Copy link
Contributor Author

skliper commented Feb 4, 2021

@astrogeco Removing the classic text startup script wasn't accepted as a change for Caelum by stakeholders. Could transition #660 to a module along side the classic method (projects could select either option at least for a while), but not a high priority (not a cert issue).

@astrogeco astrogeco merged commit e0cb584 into nasa:integration-candidate Feb 4, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 4, 2021
@skliper skliper deleted the fix680-conditional_tbl branch March 23, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove conditional TBL compilation logic
2 participants