Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #915, Check for file existence in CFE_ES_RestartApp #1128

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 25, 2021

Describe the contribution
Fix #915 - CFE_ES_RestartApp now checkes for file existence as part of command processing. Avoids removing the app if the file doesn't exist (just avoids one error case).

Testing performed
Build and ran unit tests, passed. Also ran cFE and tested with valid and invalid file (moved good file), confirmed error counter increment (and command rejected so app remained running).

Expected behavior changes
Now rejects command and increments command error counter if file is missing

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
#915

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 25, 2021
@skliper skliper added this to the 7.0.0 milestone Jan 25, 2021
@skliper skliper force-pushed the fix915-restart_file_check branch from 40d5b81 to 79c4210 Compare January 27, 2021 14:38
@astrogeco astrogeco added CCB:2021-01-27 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 27, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Jan 27, 2021

CB:2021-01-27 APPROVED

  • At least checks that the file exists
  • Avoids unloading
  • Follows the flow of restart and reload

@astrogeco astrogeco changed the base branch from main to integration-candidate February 3, 2021 19:27
@astrogeco astrogeco merged commit d9f3fa4 into nasa:integration-candidate Feb 3, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 3, 2021
@skliper skliper deleted the fix915-restart_file_check branch March 23, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cFE req. cES1007.2: Restart Application - Reject On Missing File
2 participants