Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1122, ES and EVS use default message limits #1126

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Fix #1122, ES and EVS use default message limits #1126

merged 1 commit into from
Feb 4, 2021

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 25, 2021

Describe the contribution
Fix #1122 - ES and EVS used CFE_SB_SubscribeEx with no requirement or justification (all but one of the limits were default, and the non-default for ES HK was 2 vs 4). Default limits should be fine unless required to be different.

Testing performed
Built and ran unit tests, passed

Expected behavior changes
None except it could queue a few more HK messages, but SCH loads after ES anyways.

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 25, 2021
@skliper skliper added this to the 7.0.0 milestone Jan 25, 2021
@skliper skliper mentioned this pull request Jan 25, 2021
Merged
@skliper skliper force-pushed the fix1122-default_subscribe branch from 06b226f to 68ccd7a Compare January 27, 2021 14:42
@astrogeco astrogeco added CCB:2021-01-27 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 27, 2021
@astrogeco
Copy link
Contributor

CCB:2021-01-27 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate February 4, 2021 18:36
@astrogeco astrogeco merged commit 4c441b0 into nasa:integration-candidate Feb 4, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 4, 2021
@astrogeco
Add cFE PRs
3a0f8cf 
nasa/cFE#1132
nasa/cFE#1129
nasa/cFE#1126
@astrogeco astrogeco mentioned this pull request Feb 15, 2021
Merged
@skliper skliper deleted the fix1122-default_subscribe branch March 23, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Caelum
Development

Successfully merging this pull request may close these issues.

Custom pipe message limits without requirements or justification
2 participants
@skliper @astrogeco