Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #260, Remove unused network_includes.h #1067

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 6, 2021

Describe the contribution
Fix #260 - removes network_includes.h (not used anywhere, and apps should use OSAL APIs)

Testing performed
Built with file removed (no dependencies)

Expected behavior changes
None

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added CCB:FastTrack CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 6, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate January 11, 2021 16:06
@skliper skliper linked an issue Jan 11, 2021 that may be closed by this pull request
@astrogeco astrogeco merged commit fb18780 into nasa:integration-candidate Jan 12, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 12, 2021
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 13, 2021
@skliper skliper deleted the fix260-rm_network_includes branch February 1, 2021 22:05
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network_includes.h needs to include sioLib.h for VxWorks target Deprecate / remove network_includes.h?
2 participants