Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cFS Bundle Integration Candidate: 2021-01-12 #174

Merged
merged 18 commits into from
Jan 13, 2021
Merged

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Jan 12, 2021

Describe the contribution

Combines

Testing performed
See https://github.com/nasa/cFS/pull/174/checks

Expected behavior changes
See submodule PRs

System(s) tested on
Ubuntu 18.04

Additional context
None

Code contibutions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
@skliper
@jphickey
@zanzaben
@CDKnightNASA

@astrogeco
Copy link
Contributor Author

astrogeco commented Jan 12, 2021

@skliper @jphickey still have 57: select-test hanging. See https://github.com/nasa/cFS/pull/174/checks?check_run_id=1689399944

Wasn't this fixed by nasa/osal#721?

@skliper
Copy link
Contributor

skliper commented Jan 12, 2021

@astrogeco it should have, maybe there is another issue...

@skliper
Copy link
Contributor

skliper commented Jan 12, 2021

@skliper @jphickey still have 57: select-test hanging. See https://github.com/nasa/cFS/pull/174/checks?check_run_id=1689399944

Wasn't this fixed by nasa/osal#721?

@zanzaben - could you prioritize looking into this?

@zanzaben
Copy link
Contributor

@skliper @jphickey still have 57: select-test hanging. See https://github.com/nasa/cFS/pull/174/checks?check_run_id=1689399944

Wasn't this fixed by nasa/osal#721?

How often did it happen?

@astrogeco
Copy link
Contributor Author

@skliper @jphickey still have 57: select-test hanging. See https://github.com/nasa/cFS/pull/174/checks?check_run_id=1689399944
Wasn't this fixed by nasa/osal#721?

How often did it happen?

Here is another instance
https://github.com/nasa/cFS/runs/1690379753?check_suite_focus=true

@astrogeco
Copy link
Contributor Author

@zanzaben
Copy link
Contributor

And one more
https://github.com/nasa/cFS/pull/174/checks?check_run_id=1690641558

Thank you, I understand the issue now and am working on a fix.

@skliper
Copy link
Contributor

skliper commented Jan 12, 2021

I recommend merging in the PR as a hotfix so it gets exercised this round if possible.

@astrogeco
Copy link
Contributor Author

I recommend merging in the PR as a hotfix so it gets exercised this round if possible.

Adding information for completeness,

Issue: nasa/osal#755 "resolve subtasks not ending on time "

and

PR: nasa/osal#756

@astrogeco astrogeco marked this pull request as ready for review January 13, 2021 23:35
@astrogeco astrogeco merged commit 9dd4ec7 into main Jan 13, 2021
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
Fix nasa#40, update traverse history/write file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants