-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #581, Broken links in docs #582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SCH can also be added to line 171.
Hi @thnkslprpt , thank you for the pull request. It looks good! Just some comments about SCH. |
No worries mate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to follow a commit message convention throughout all cFS. At least, we want to change the commit message: "Add SCH to list of apps". Would you please squash the commits? git rebase -i HEAD~3
from your local cFS repo, squash the latter 2 commits, reword the 1 commit to "Fix #581, Updates broken links in docs". I think this makes sense since most of this pr's work is in lieu with that message. What do you think?
Yeah that makes sense Justin. Let me know if I've updated it successfully now. |
*Combines:* osal v6.0.0-rc4+dev173 cFE v7.0.0-rc4+dev229 **Includes:** *cFS* - #622 - #625 - #626 - #582 *osal* - nasa/osal#1342 - nasa/osal#1341 - nasa/osal#1321 *cFE* - nasa/cFE#2215 - nasa/cFE#2219 - nasa/cFE#2217 - nasa/cFE#2222 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Daniel Knutsen <[email protected]> Co-authored by: Avi Weiss: <[email protected]>
*Combines:* osal v6.0.0-rc4+dev173 cFE v7.0.0-rc4+dev229 **Includes:** *cFS* - #622 - #625 - #626 - #582 *osal* - nasa/osal#1342 - nasa/osal#1341 - nasa/osal#1321 *cFE* - nasa/cFE#2215 - nasa/cFE#2219 - nasa/cFE#2217 - nasa/cFE#2222 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Daniel Knutsen <[email protected]> Co-authored by: Avi Weiss: <[email protected]>
Checklist (Please check before submitting)
Describe the contribution
Fixes #581
Corrects a few broken links in the contributing guide.
Also cleaned up a few other links for consistency.
Testing performed
Tested the links - working now.
Expected behavior changes
Links will work.
System(s) tested on
Chrome browser.
Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt