You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reviewed the cFS README.md file to see if the feature is in the major future work.
I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.
Is your feature request related to a problem? Please describe.
The CodeQL and static analysis workflows should are already checked at the submodule level.
Furthermore, the github security scanning dashboard doesn't work well with SARIF files that point to files from submodule so running the CodeQL workflow with each commit or PR doesn't help.
Describe the solution you'd like
Remove pull request and push triggers from CodeQL and cppcheck workflows. Keep them as "workflow dispatch" in case someone wants to run the analysis on the bundle.
Describe alternatives you've considered
a) Keep as is.
b) Completely remove workflows
Additional context
None
Requester Info
Gerardo E. Cruz-Ortiz, NASA
The text was updated successfully, but these errors were encountered:
I recommend keeping cppcheck in the cFS workflow since it covers all the c code in the bundle. Individual repos only check their c code, so if an issue was introduced during integration at the cFS level, it wouldn't be caught until whatever repo it was introduced in actually does another cppcheck run (which could easily be months).
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe.
The CodeQL and static analysis workflows should are already checked at the submodule level.
Furthermore, the github security scanning dashboard doesn't work well with SARIF files that point to files from submodule so running the CodeQL workflow with each commit or PR doesn't help.
Describe the solution you'd like
Remove pull request and push triggers from CodeQL and cppcheck workflows. Keep them as "workflow dispatch" in case someone wants to run the analysis on the bundle.
Describe alternatives you've considered
a) Keep as is.
b) Completely remove workflows
Additional context
None
Requester Info
Gerardo E. Cruz-Ortiz, NASA
The text was updated successfully, but these errors were encountered: