Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CodeQL and cppcheck workflow runs for cFS Bundle #488

Open
1 of 3 tasks
astrogeco opened this issue May 19, 2022 · 1 comment
Open
1 of 3 tasks

Disable CodeQL and cppcheck workflow runs for cFS Bundle #488

astrogeco opened this issue May 19, 2022 · 1 comment

Comments

@astrogeco
Copy link
Contributor

astrogeco commented May 19, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the cFS README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
The CodeQL and static analysis workflows should are already checked at the submodule level.
Furthermore, the github security scanning dashboard doesn't work well with SARIF files that point to files from submodule so running the CodeQL workflow with each commit or PR doesn't help.

Describe the solution you'd like
Remove pull request and push triggers from CodeQL and cppcheck workflows. Keep them as "workflow dispatch" in case someone wants to run the analysis on the bundle.

Describe alternatives you've considered
a) Keep as is.
b) Completely remove workflows

Additional context
None

Requester Info
Gerardo E. Cruz-Ortiz, NASA

@skliper
Copy link
Contributor

skliper commented May 19, 2022

I recommend keeping cppcheck in the cFS workflow since it covers all the c code in the bundle. Individual repos only check their c code, so if an issue was introduced during integration at the cFS level, it wouldn't be caught until whatever repo it was introduced in actually does another cppcheck run (which could easily be months).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants