Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #465 #463, CI document deployment fixes #466

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Apr 21, 2022

Checklist (Please check before submitting)

Describe the contribution

Now always running for main branch actions (will deploy on fork if you push main). Also rejecting attempts to deploy and use the cache at the same time since I can't figure out how to make that work (password fails on deploy).

Testing performed
Tested w/ a push of main to my fork at https://github.com/skliper/cFE/actions/runs/2203904971, note that branch also contains updates to deploy locally to avoid the password issue.

Expected behavior changes
Deploy on push to main

System(s) tested on
CI

Additional context
Only caller impact is for cFE that tried to use the cache and reusable deploy. CF and cFS workflows not impacted.

Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 21, 2022
@skliper skliper added this to the Draco milestone Apr 21, 2022
@astrogeco astrogeco merged commit 753ed54 into nasa:main Apr 25, 2022
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 2, 2022
@skliper skliper deleted the fix465-doc_deploy_fixes branch September 19, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB CCB:FastTrack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document deployment reusable workflow fails deploy step Docs not deployed when PR is merged to main
2 participants