-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No tests were found #113
Comments
Note - something like this could be caused by submodules being out of sync. Can you confirm if you did a "git submodule update' as part of this? There was a recent change that affected the directory structure of the build tree, so if this was out of sync it would potentially manifest as not finding any test files. |
Yes, I forgot to include the |
Did you do this before or after the "cp cfe/cmake/Makefile.sample Makefile" step? The sample makefile might contain a line "ARCH ?= native" or "ARCH ?= native/default_cpu1" reflecting the recent change to the build tree. Check your generated build tree and see if the actual build binaries are in the "native" subdir or a "native/default_cpu1" subdir. |
I updated the submodules prior to copying the Makefile, even after changing to the The sample Makefile I copied has |
Ah hah --- I see it -- |
🤦 Yes! Thank you!! |
Fixes nasa#112 Code reviewed and approved at 20191106 CCB
Using a union for the ack/nak counts is somewhat dangerous because undefined behavior will occur if accessed improperly. In this case there is no need to have separate representations of the counter, they are both limited to the "unit8" range, so use a uint8.
The use of random numbers in a couple test cases was causing an unpredictable flow through the code. This replaces with fixed values so get consistent flows. Specifically, the "acknak_count" should always be less than the "ack_limit". The UT use of random numbers allowed it to be greater. However, if it is greater than the limit, it should still follow the limit/error path, not the successful path.
Fix nasa#113, replace acknack count union
Describe the bug
make test
on a freshly cloned repository does not find any tests.To Reproduce
Steps to reproduce the behavior:
git clone https://github.com/nasa/cFS.git
cd cFS
cp cfe/cmake/Makefile.sample Makefile
cp -r cfe/cmake/sample_defs sample_defs1
make SIMULATION=native ENABLE_UNIT_TEST=true prep
make
make install
make test
Observed behavior
Expected behavior
Tests run and pass.
System observed on:
VirtualBox 6.1 running Linux Mint 20, Kernel: Linux 5.4.0-40-generic, Architecture: x86-64
The text was updated successfully, but these errors were encountered: