From c37762946864385f576be810fba7d947120138b2 Mon Sep 17 00:00:00 2001 From: Jacob Hageman Date: Mon, 27 Jul 2020 17:48:38 -0400 Subject: [PATCH] Fix #118, Resolve LGTM warnings - Resolves commented out code warnings - Resolves unused packages in hand generated code --- Subsystems/cmdGui/Parameter.py | 8 -------- Subsystems/cmdGui/UdpCommands.py | 5 ----- Subsystems/tlmGUI/TelemetrySystem.py | 5 ----- 3 files changed, 18 deletions(-) diff --git a/Subsystems/cmdGui/Parameter.py b/Subsystems/cmdGui/Parameter.py index d17688a..c353fe5 100644 --- a/Subsystems/cmdGui/Parameter.py +++ b/Subsystems/cmdGui/Parameter.py @@ -20,8 +20,6 @@ import getopt import pickle import re -import shlex -import subprocess import sys from pathlib import Path @@ -68,12 +66,6 @@ def ProcessSendButton(self): self.mcu = MiniCmdUtil(pageAddress, pagePort, pageEndian, pagePktId, cmdCode, param_string.strip()) sendSuccess = self.mcu.sendPacket() - # launch_string = ( - # f'{ROOTDIR.parent}/cmdUtil/cmdUtil --host={pageAddress} ' - # f'--port={pagePort} --pktid={pagePktId} --endian={pageEndian} ' - # f'--cmdcode={cmdCode} {param_string.strip()}')result - # cmd_args = shlex.split(launch_string) - # subprocess.Popen(cmd_args) if sendSuccess: self.status_box.setText('Command sent!') else: diff --git a/Subsystems/cmdGui/UdpCommands.py b/Subsystems/cmdGui/UdpCommands.py index e3758c5..c1e18b6 100644 --- a/Subsystems/cmdGui/UdpCommands.py +++ b/Subsystems/cmdGui/UdpCommands.py @@ -58,11 +58,6 @@ def __init__(self): self.setWindowTitle(pageTitle) self.mcu = None - # for j in range(self.tblCommands.rowCount()): - # btn = self.tblCommands.cellWidget(j, 1) - # btn.clicked.connect( - # lambda _, x=j: self.ProcessSendButtonGeneric(x)) - # # Determines if command requires parameters # diff --git a/Subsystems/tlmGUI/TelemetrySystem.py b/Subsystems/tlmGUI/TelemetrySystem.py index 616a2b3..b0fb831 100644 --- a/Subsystems/tlmGUI/TelemetrySystem.py +++ b/Subsystems/tlmGUI/TelemetrySystem.py @@ -50,11 +50,6 @@ def __init__(self): self.pktCount = 0 self.subscription = None - # for k in range(21): - # pushButton = getattr(self, f"pushButton_{k}") - # pushButton.clicked.connect( - # lambda _, x=k: self.ProcessButtonGeneric(x)) - # # convert a string of binary bytes to ascii hex #