cFE Integration candidate: Equuleus-rc1+dev13 #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up the internal SB implementation so it can better support future enhancements such as message integrity, additional header fields and timestamping.
Use a resourceID value for access into the validation result structure array. This allows for consistent lookup, matching, and free/in-use determination, as well as improved resilience to race conditions and stale data.
Use a resourceID value for access into the dump control structure array. This allows for consistent lookup, matching, and free/in-use determination, as well as improved resilience to race conditions and stale data.
Restructure some switch statements and add a "default" case so they are not flagged as having a missing branch in the coverage test.
Fix #2553, fix test that was passing null value into vsnprintf
Fix #2550, use resourceids for internal table validation and dump control blocks
Fix #2378, refactor SB to support additional use cases
Fix #2536, msg api test buffer overrun
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * Not invoked outside of this unit | ||
| * | ||
| *-----------------------------------------------------------------*/ | ||
| void CFE_SB_MessageTxn_GetEventDetails(const CFE_SB_MessageTxn_State_t *TxnPtr, const CFE_SB_PipeSetEntry_t *ContextPtr, |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
| DumpCtrlPtr->State = CFE_TBL_DUMP_PENDING; | ||
| DumpCtrlPtr->BlockId = CFE_TBL_DUMPCTRLID_C(PendingId); | ||
| DumpCtrlPtr->RegRecPtr = RegRecPtr; | ||
| DumpCtrlPtr->DumpBufferPtr = DumpBufferPtr; |
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning
There was a problem hiding this comment.
CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
dzbaker
changed the title
…aracter truncation
…_report Fix #2559, Improve CFE_SB_AllocateMessageBuffer error report
Fix #2343, Update CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODE macro in es_verify.h
…n-for-CFE-PLATFORM-SB-HIGHEST-VALID-MSGID Fix #2116, Update comment re. limits of CFE_PLATFORM_SB_HIGHEST_VALID_MSGID
…-variables-and-parameters Fix #2375, Use size_t for variables/parameters representing size
…tatus-assignment-in-CFE_SB_CreatePipe Fix #2495, Remove superfluous status assignment in CFE_SB_CreatePipe
Fix #2553, null value in vsnprintf
Fix #2552, Adds JSC 2.1 Static Analysis comments
Fix #2529, Reduces CFE_EVS_MAX_PORT_MSG_LENGTH to prevent new line character truncation
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODEmacro in es_verify.h #2344. Addresses Issue Out-of-dateCFE_PLATFORM_ES_DEFAULT_SYSLOG_MODEmacro in cfe_es_verify.h #2343CFE_PLATFORM_SB_HIGHEST_VALID_MSGID#2359. Addresses Issue Update wrong comment regarding the value of CFE_SB_INVALID_MSG_ID #2116size_tfor variables/parameters representing size #2376. Addresses Issue Usesize_tfor variables/parameters representing size #2375CFE_SB_CreatePipe#2496. Addresses Issue Superfluous status assignment inCFE_SB_CreatePipeafter return fromOS_QueueCreate#2495Testing performed
cFS Bundle Checks
cFE Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 20.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@skliper
@thnkslprpt
@avan989
@chillfig