Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "special" ES shell commands as real commands #643

Open
skliper opened this issue Apr 27, 2020 · 4 comments
Open

Add "special" ES shell commands as real commands #643

skliper opened this issue Apr 27, 2020 · 4 comments

Comments

@skliper
Copy link
Contributor

skliper commented Apr 27, 2020

Is your feature request related to a problem? Please describe.
ES special commands using the SHELL FC and a special string don't follow command processing model, missing requirements, etc
CFE_ES_ListApplications
CFE_ES_ListTasks
CFE_ES_ListResources

Describe the solution you'd like
Implement these as real commands

Describe alternatives you've considered
Delete these

Additional context
#484

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added enhancement CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 27, 2020
@skliper
Copy link
Contributor Author

skliper commented Apr 27, 2020

Other options - Could add an event as part of QueryAllCmd (prints name to replace CFE_ES_ListApplications), QuerryAllTasksCmd (prints task name/id, app name/id to replace CFE_ES_ListTasks).

Note CFE_ES_ListResources still seems unique/useful but it only does counts. Might make more sense to include names or possibly other info... or maybe would make even more sense to include resource counts in the housekeeping message? It's got counts for core apps, external apps, tasks, libs, why not resources? Or maybe just a by request packet (add new) that has all the counts? Send to a file doesn't really seem to have that much of a benefit.

@astrogeco
Copy link
Contributor

CCB 2020-04-29 : Discussed

@skliper
Copy link
Contributor Author

skliper commented Apr 29, 2020

Note - no strong opinions expressed, seems like approach in the comments above would be beneficial to users. Suggesting that as a path forward (events for the name/tasks as part of the already existing commands, new more informative output for resources).

@astrogeco astrogeco added CCB-20200429 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 5, 2020
@skliper skliper removed the CCB:Approved Indicates code review and approval by community CCB label May 7, 2020
@igorluppi
Copy link

Is this thread still open for draco-rc4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants