Fix #2625, add initialization of table indices #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
jphickey
force-pushed
the
fix-2625-tbl-validate
branch
from
de95f21 to
9f58cb3
Compare
The "Last" ID values that are tracked in the CFE_TBL_Global were not initialized correctly, thus making it fail to get a record. This in turn caused the "Too many validations" issue, because it could not get a result buffer.
jphickey
force-pushed
the
fix-2625-tbl-validate
branch
from
9f58cb3 to
3091b2a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| CFE_TBL_Global.Registry[2].Buffers[CFE_TBL_Global.Registry[2].ActiveBufferIndex].BufferPtr = BuffPtr; | ||
|
|
||
| UT_SetDeferredRetcode(UT_KEY(CFE_ResourceId_FindNext), 1, -1); | ||
| UtAssert_INT32_EQ(CFE_TBL_DumpCmd(&DumpCmd), CFE_TBL_INC_ERR_CTR); |
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning
dzbaker
added
CCB:Approved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
The "Last" ID values that are tracked in the CFE_TBL_Global were not initialized correctly, thus making it fail to get a record. This in turn caused the "Too many validations" issue, because it could not get a result buffer.
Fixes #2625
Testing performed
Expected behavior changes
Sending the validate table command now works as expected, does not always reply with too many validations error.
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.