Fix #2610, Enforce keeping coverage minimums up-to-date in Code Coverage CI workflow #2611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
allowed_missed_lines
to 17 (from 19)Testing performed
Tested all variations of coverage thresholds (above, below, split between functions/lines/branches etc.) to confirm expected behavior.
New checks:
![Screenshot 2024-10-11 18 28 42](https://private-user-images.githubusercontent.com/9024662/375825971-595e0f20-2756-48fd-8fd5-9ccaf78736a7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Nzc4NzMsIm5iZiI6MTczODk3NzU3MywicGF0aCI6Ii85MDI0NjYyLzM3NTgyNTk3MS01OTVlMGYyMC0yNzU2LTQ4ZmQtOGZkNS05Y2NhZjc4NzM2YTcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDhUMDExOTMzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDAwNDYyNDFkY2I4ZDk0NTNiMDZjZDQ0MWZmMWMxN2E5MzUwYTNhM2ZhMjQ3YzcyMmRiNWNhMTAxZmM0NTg4MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.txUZzSYLzzVzgSAp7KGJ3QEtovYQrSRURWX-A3dB_nA)
Expected behavior changes
Any PR that improves coverage will cause the workflow to fail now unless the
ALLOWED_MISSED_BRANCHES
,ALLOWED_MISSED_LINES
and/orALLOWED_MISSED_FUNCTIONS
variables are updated as part of the same PR. This will avoid cases like the present, where there is a gap, and a new PR could theoretically reduce coverage but give no warning of the fact.System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt