Fix #1360, Limit HK Commands to 1 in pipe + replace hand-written function names with __func__

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to [email protected] and copied [email protected].

Describe the contribution

• Fixes Limit send HK MID's to 1 in pipe #1360
  • Limits Send HK MIDs in the ES command pipe to 1 at a time using CFE_SB_SubscribeEx()
  • Also piggy-backing on this PR are a few typo fixes, updates to out-of-date identifiers, and replacing hand-written function names with __func__ (to reduce chances of these coming out of sync in the future)

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
Send HK MIDs in ES command pipe will be explicitly limited to 1 at a time instead of whatever the default is set to (currently 4).

Contributor Info
Avi Weiss   @thnkslprpt

[jphickey]

I think the comment/syslog cleanup is a good change, no issue there. But the pipe depth change might entail more review. I do think it makes sense for a SEND_HK request to be limited at 1 though, so I think this is worth discussion.

[skliper]

Changing to one was a code review suggestion. If there's more than one something is probably broken or at least extremely delayed and worth notifying the user (via the event from SB on msg limited). I can't imagine a use case for having more than one in the pipe, but maybe I'm not imaginative enough?

[dzbaker]

24 October 2024: Discussed change. There is some uncertainty whether or not we do want to limit it to 1. If we do, we would want to do that for all scheduling/wake up-related MIDs, not just HK ones. Recommend testing (such as in BVT) to determine whether or not limiting to 1 makes sense.

[chillfig]

Ran ctf tests with this commit cherry-picked on top today and the results show that there are no new failures introduced. Ran all ES, EVS, SB, TBL, and TIME ctf tests.

[dzbaker]

CCB 31 October 2024: Deferring for now; will revisit later on to make changes more holistically to other sets of MIDs.