Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2444, Enforce keeping code coverage minimums up-to-date #2445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
Tested all variations of coverage thresholds (above, below, split between lines/branches etc.) to confirm expected behavior.

New checks:
Screenshot 2023-09-22 22 34 18

Confirm Minimum Coverage logic/failure is unchanged:
Screenshot 2023-09-22 22 35 14

Expected behavior changes
Any PR that improves coverage will cause the workflow to fail now, unless the MISSED_LINES_ALLOWED and/or MISSED_BRANCHES_ALLOWED variables are updated (lowered) as well.

System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@thnkslprpt
Copy link
Contributor Author

Note: Unlike the logic in OSAL (https://github.com/nasa/osal/blob/main/.github/workflows/standalone-build.yml), cFE doesn't currently check for full coverage of functions directly (only lines and branches). I can add that in here with this PR if desired.

@thnkslprpt thnkslprpt force-pushed the fix-2444-enforce-coverage-minimums-updating branch 2 times, most recently from 0b863db to e614d1e Compare March 23, 2024 11:05
@dzbaker dzbaker self-assigned this May 2, 2024
@thnkslprpt thnkslprpt force-pushed the fix-2444-enforce-coverage-minimums-updating branch from e614d1e to 502dddb Compare July 9, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce keeping coverage minimums up-to-date in Code Coverage CI workflow
2 participants