Fix #1428, Refactor error handling for EVS_GetApplicationInfo() #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * event from the calling function. | ||
| * | ||
| *-----------------------------------------------------------------*/ | ||
| void CFE_EVS_SendEventForGetAppInfoError(int32 Status, const char *LocalName, uint16 CommandCode) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
thnkslprpt
force-pushed
the
fix-1428-refactor-error-handling-for-GetAppInfo
branch
2 times, most recently
from
f3eed39 to
d624e79
Compare
|
You have successfully added a new CodeQL configuration |
|
You have successfully added a new CodeQL configuration |
thnkslprpt
force-pushed
the
fix-1428-refactor-error-handling-for-GetAppInfo
branch
from
d624e79 to
8679507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
EVS_GetApplicationInforeturn to eliminate duplication #1428EVS_GetApplicationInfo()into a single helper function.The function prototype isn't strictly required, given the placement of the function definition, but is probably worth having to improve clarity and ease future maintenance.
Can also be implemented as an if/else if/else block (see below). No strong preference but I've left it as a switch for now.
Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Tested locally as well and confirmed coverage of all new/amended lines of code via LCOV report.
Expected behavior changes
No impact on behavior. The same events will occur in the same circumstances.
System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch cFS bundle.
cFE v7.0.0-rc4+dev205
Contributor Info
Avi Weiss @thnkslprpt