Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move writing of the event log to the FS background service #1405

Open
skliper opened this issue Apr 21, 2021 · 3 comments
Open

Move writing of the event log to the FS background service #1405

skliper opened this issue Apr 21, 2021 · 3 comments

Comments

@skliper
Copy link
Contributor

skliper commented Apr 21, 2021

Is your feature request related to a problem? Please describe.
Writing the event log could take a while and is done in the EVS context by command:

/*
** Function Prologue
**
** Function Name: CFE_EVS_WriteLogDataFileCmd
**
** Purpose: This routine writes the contents of the internal event log to a file
**
** Assumptions and Notes:
**
*/
int32 CFE_EVS_WriteLogDataFileCmd(const CFE_EVS_WriteLogDataFileCmd_t *data)

Describe the solution you'd like
Move to the FS background service like the rest of the logs

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Apr 30, 2021

Might benefit from the general solution to #1473 (related to #994)

@skliper
Copy link
Contributor Author

skliper commented Aug 31, 2022

Note since the semaphore is locked for both file writing and sending events, any task trying to send an event will get held up until the write completes.

@keegan-moore
Copy link

This sounds like it could cause serious priority inversion problems. Is there a plan to address this soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants