Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should CFE_EVS_Register() be called with CFE_EVS_NO_FILTER or CFE_EVS_EventFilter_BINARY? #91

Open
2 tasks done
thnkslprpt opened this issue May 3, 2023 · 0 comments
Labels

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Shouldn't SC be calling CFE_EVS_Register() with CFE_EVS_EventFilter_BINARY for the FilterScheme parameter? (rather than CFE_EVS_NO_FILTER)

They both end up as the integer zero, so the check here will treat them the same:
https://github.com/nasa/cFE/blob/7479d221692672d66946081f1cc5eb7c1d2acf9b/modules/evs/fsw/src/cfe_evs.c#L59-L68

A couple of other apps (CS and DS) actually just call it directly with 0 like so:
Result = CFE_EVS_Register(NULL, 0, 0);
...which also seems wrong (they should also just use CFE_EVS_EventFilter_BINARY directly).

Code snips

Result = CFE_EVS_Register(NULL, 0, CFE_EVS_NO_FILTER);

Reporter Info
Avi Weiss @thnkslprpt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants