Should CFE_EVS_Register()
be called with CFE_EVS_NO_FILTER
or CFE_EVS_EventFilter_BINARY
?
#91
Labels
CFE_EVS_Register()
be called with CFE_EVS_NO_FILTER
or CFE_EVS_EventFilter_BINARY
?
#91
Checklist
Describe the bug
Shouldn't SC be calling
CFE_EVS_Register()
withCFE_EVS_EventFilter_BINARY
for theFilterScheme
parameter? (rather thanCFE_EVS_NO_FILTER
)They both end up as the integer zero, so the check here will treat them the same:
https://github.com/nasa/cFE/blob/7479d221692672d66946081f1cc5eb7c1d2acf9b/modules/evs/fsw/src/cfe_evs.c#L59-L68
A couple of other apps (CS and DS) actually just call it directly with
0
like so:Result = CFE_EVS_Register(NULL, 0, 0);
...which also seems wrong (they should also just use
CFE_EVS_EventFilter_BINARY
directly).Code snips
SC/fsw/src/sc_app.c
Line 172 in 487169b
Reporter Info
Avi Weiss @thnkslprpt
The text was updated successfully, but these errors were encountered: