Fix #54, Remove unnecessary parentheses around return values.

[thnkslprpt]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to [email protected] and copied [email protected].

Describe the contribution

• Fixes Scrub use of () in return statements #54
  • Removes parentheses in return statements in SC that return a single value/term.

This aligns these return statements with the predominant style of cFS.

Testing performed
None, prior to submission of the pull request.

Expected behavior changes
No impact on behavior.

Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt

[dzbaker]

@thnkslprpt Would you be able to resolve the conflicts?

[thnkslprpt]

@thnkslprpt Would you be able to resolve the conflicts?

I think it's resolved now.
I added another commit to fix the rest of the cases (of parentheses around return values) that were introduced after the merge conflict resolution.
Should I squash those commits together now?

[dzbaker]

@thnkslprpt Would you be able to resolve the conflicts?

I think it's resolved now. I added another commit to fix the rest of the cases (of parentheses around return values) that were introduced after the merge conflict resolution. Should I squash those commits together now?

Thanks! That would be good. I'll add this to the CCB agenda for today just so everyone can take a quick look since the scope increased a bit.

[dzbaker]

@thnkslprpt CCB 6 October 2022: Approved pending resolution of failed workflow checks.

[dzbaker]

@thnkslprpt Would you be able to squash together the commits (so the commit message check passes)?

[thnkslprpt]

@thnkslprpt Would you be able to squash together the commits (so the commit message check passes)?

Hi @dzbaker - I may need a bit of a hand with that...
I tried a few times but just ended up tying myself in knots.

[dzbaker]

@thnkslprpt Would you be able to squash together the commits (so the commit message check passes)?

Hi @dzbaker - I may need a bit of a hand with that... I tried a few times but just ended up tying myself in knots.

@thnkslprpt Hmm, that's odd. Are you able to change the commit message for the merge commit (using "git commit --amend") instead?

[thnkslprpt]

@thnkslprpt Hmm, that's odd. Are you able to change the commit message for the merge commit (using "git commit --amend") instead?

I couldn't get it working in the original local git repository I used for these changes, but by opening a clean folder and cloning it in again, git finally let me amend the commit message of the merge commit. Still didn't let me squash them together, though...

[thnkslprpt]

With the help of @skliper I was finally able to squash these 3 commits incl. the merge resolution into 1 clean commit.