Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #168, PSP coverage unit test #174

Merged

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Jun 16, 2020

Describe the contribution
Add a framework and example for coverage test of the PSP code.

Fix #168

Testing performed
Build and run unit test
Build and sanity check CFE (no changes to FSW)

Expected behavior changes
New PSP coverage test executable is built, and several files within PSP are targeted.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey
Copy link
Contributor Author

Only commit 892880a is relevant. Will rebase after the next baseline.

The following mcp750-vxworks PSP files are currently covered as an example:
fsw/mcp750-vxworks/src/cfe_psp_support.c
fsw/mcp750-vxworks/src/cfe_psp_start.c
fsw/shared/src/cfe_psp_exceptionstorage.c

Comment on lines +60 to +62
foreach(TGT ${INSTALL_TARGET_LIST})
install(TARGETS coverage-${CFE_PSP_TARGETNAME}-testrunner DESTINATION ${TGTNAME}/${UT_INSTALL_SUBDIR})
endforeach()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TGT not used in install line, why foreach?

@skliper
Copy link
Contributor

skliper commented Jul 24, 2020

Also related to #14

@skliper
Copy link
Contributor

skliper commented Jul 29, 2020

What's the status on this, can it be reviewed today?

Implement a basic example of PSP coverage test.
@jphickey jphickey force-pushed the fix-168-psp-coverage-ut branch from 892880a to 597921e Compare July 29, 2020 14:24
@jphickey jphickey marked this pull request as ready for review July 29, 2020 14:25
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jul 29, 2020
@jphickey
Copy link
Contributor Author

Rebased to "main" -- yes this can be reviewed today.

@astrogeco astrogeco modified the milestones: 1.5.0, 1.6 Jul 29, 2020
@astrogeco astrogeco changed the base branch from master to main August 5, 2020 02:25
@astrogeco
Copy link
Contributor

CCB 2020-07-29 APPROVED

@astrogeco astrogeco added CCB:Approved Indicates Approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Aug 5, 2020
@astrogeco
Copy link
Contributor

@skliper do you want to add this to Bootes or push to Caelum?

@skliper
Copy link
Contributor

skliper commented Aug 5, 2020

If you can merge it today, Bootes. My logic is there is a customer waiting on it and there is no impact to flight code. If anyone ever needs to certify Bootes it's a very valuable framework to have.

@astrogeco astrogeco changed the base branch from main to integration-candidate August 5, 2020 17:29
@astrogeco
Copy link
Contributor

We're on the same page. Done.

@astrogeco astrogeco merged commit f753a50 into nasa:integration-candidate Aug 5, 2020
@jphickey jphickey deleted the fix-168-psp-coverage-ut branch January 6, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates Approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PSP unit test framework and example
3 participants