Fix #65, Adds EventString null termination #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
chillfig
force-pushed
the
NullTerminate_EventString
branch
2 times, most recently
from
48fae2d to
5ade791
Compare
chillfig
commented
Apr 13, 2023
fsw/src/mm_dump.c
Outdated
| @@ -517,6 +518,7 @@ bool MM_DumpInEventCmd(const CFE_SB_Buffer_t *BufPtr) | |||
| ** 13 characters, not counting NUL terminator | |||
| */ | |||
| strncpy(EventString, "Memory Dump: ", CFE_MISSION_EVS_MAX_MESSAGE_LENGTH); | |||
There was a problem hiding this comment.
"Memory Dump: " may exceed length of CFE_MISSION_EVS_MAX_MESSAGE_LENGTH when CFE_MISSION_EVS_MAX_MESSAGE_LENGTH is configured less than size 14.
Ensure this is null terminated. Could just use CFE_SB_MessageStringGet()
chillfig
force-pushed
the
NullTerminate_EventString
branch
from
5ade791 to
e026d91
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Testing performed
./runCTFscript.sh cFE_MM_DumpInEventRAM.jsontestExpected behavior changes
Null terminated
EventStringSystem(s) tested on
Additional context
Followed similar null-terminated character array concatenation in:https://github.com/nasa/DS/blob/64181647ab455653fbc04b20a43406764862673b/fsw/src/ds_file.c#L553
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request