Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #90, Convert int32 return codes and variables to CFE_Status_t #91

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully.

Expected behavior changes
No change to behavior.
CFE_Status_t is more expressive and improves consistency with cFE/cFS.

Contributor Info
Avi Weiss @thnkslprpt

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@dzbaker dzbaker requested a review from chillfig April 27, 2023 18:40
@thnkslprpt thnkslprpt force-pushed the fix-90-convert-int32-return-codes-to-CFE_Status_t branch from 08196a3 to ac3c619 Compare May 5, 2023 02:57
@thnkslprpt thnkslprpt force-pushed the fix-90-convert-int32-return-codes-to-CFE_Status_t branch from ac3c619 to 2f7419d Compare May 11, 2023 20:22
Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dzbaker dzbaker merged commit 9da6fb7 into nasa:main May 18, 2023
@thnkslprpt thnkslprpt deleted the fix-90-convert-int32-return-codes-to-CFE_Status_t branch May 18, 2023 21:21
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LC int32 return codes and variables should be converted to CFE_Status_t
4 participants