-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #43, Remove use of 'dummy' in test code #44
Fix #43, Remove use of 'dummy' in test code #44
Conversation
8cfdaff
to
3dfddf0
Compare
You have successfully added a new CodeQL configuration |
You have successfully added a new CodeQL configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@thnkslprpt CCB 6 April 2023: Would you be able to resolve the conflicts? |
3dfddf0
to
fc060aa
Compare
All clear now @dzbaker |
Thanks! It looks like a unit test is failing now? Could it be a merge error? |
Ah yes I know what happened. Some of the dummy variables that were changed were moved completely so didn't pop up in the merge but now needs to be removed again. Will have it fixed in a minute. |
fc060aa
to
cbf495f
Compare
Working now @dzbaker |
Checklist
Describe the contribution
Fixes #43
'Dummy' removed from test code/text. Redundant.
Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No change to behavior. Simplifies test code.
Contributor Info
Avi Weiss @thnkslprpt