Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #43, Remove use of 'dummy' in test code #44

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution
Fixes #43
'Dummy' removed from test code/text. Redundant.

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
No change to behavior. Simplifies test code.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker requested a review from chillfig March 30, 2023 18:39
@thnkslprpt thnkslprpt force-pushed the fix-43-remove-dummy-from-test-code branch from 8cfdaff to 3dfddf0 Compare March 31, 2023 03:29
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration coding-standard. As part of the setup process, we have scanned this repository and found 27 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration security. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dzbaker
Copy link
Contributor

dzbaker commented Apr 6, 2023

@thnkslprpt CCB 6 April 2023: Would you be able to resolve the conflicts?

@thnkslprpt thnkslprpt force-pushed the fix-43-remove-dummy-from-test-code branch from 3dfddf0 to fc060aa Compare April 6, 2023 21:02
@thnkslprpt
Copy link
Contributor Author

@thnkslprpt CCB 6 April 2023: Would you be able to resolve the conflicts?

All clear now @dzbaker

@dzbaker
Copy link
Contributor

dzbaker commented Apr 6, 2023

@thnkslprpt CCB 6 April 2023: Would you be able to resolve the conflicts?

All clear now @dzbaker

Thanks! It looks like a unit test is failing now? Could it be a merge error?

@thnkslprpt
Copy link
Contributor Author

@thnkslprpt CCB 6 April 2023: Would you be able to resolve the conflicts?

All clear now @dzbaker

Thanks! It looks like a unit test is failing now? Could it be a merge error?

Ah yes I know what happened. Some of the dummy variables that were changed were moved completely so didn't pop up in the merge but now needs to be removed again. Will have it fixed in a minute.

@thnkslprpt thnkslprpt force-pushed the fix-43-remove-dummy-from-test-code branch from fc060aa to cbf495f Compare April 6, 2023 21:09
@thnkslprpt
Copy link
Contributor Author

@thnkslprpt CCB 6 April 2023: Would you be able to resolve the conflicts?

All clear now @dzbaker

Thanks! It looks like a unit test is failing now? Could it be a merge error?

Ah yes I know what happened. Some of the dummy variables that were changed were moved completely so didn't pop up in the merge but now needs to be removed again. Will have it fixed in a minute.

Working now @dzbaker
Cheers

@dzbaker dzbaker merged commit 83b7d08 into nasa:main Apr 6, 2023
@thnkslprpt thnkslprpt deleted the fix-43-remove-dummy-from-test-code branch April 6, 2023 21:47
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant use of "dummy" in test code
4 participants