Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #75, move app global to internal include #78

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Global data structures should not be defined in the public include files, they should be private to the local source directory.

Unit test is justified in accessing this file directly, so provisions are also made to permit this.

Fixes #75

Testing performed
Build and run all tests. Sanity check on FM running in CFE.

Expected behavior changes
No impact to behavior.
Private struct that was in public_inc is now back in a private header.

System(s) tested on
Debian

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey force-pushed the fix-75-move-app-global branch from 86ab977 to 502d77d Compare January 30, 2023 21:20
Global data structures should not be defined in the public include
files, they should be private to the local source directory.

Unit test is justified in accessing this file directly, so provisions
are also made to permit this.
@jphickey jphickey force-pushed the fix-75-move-app-global branch from 502d77d to dffbcfe Compare January 30, 2023 21:32
@dzbaker dzbaker merged commit dbe68e7 into nasa:main Feb 2, 2023
@jphickey jphickey deleted the fix-75-move-app-global branch March 7, 2023 16:22
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move "FM_GlobalData" back into private/local data structures
3 participants