Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and run existing ECI unit tests under CFE 6.6 #25

Open
BaldBeacon opened this issue Aug 6, 2019 · 4 comments
Open

Build and run existing ECI unit tests under CFE 6.6 #25

BaldBeacon opened this issue Aug 6, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@BaldBeacon
Copy link
Contributor

Since the cFE 6.6 removed the for_build directory in it's cmake build system, we are kind of lost on how to add unit tests for the cFS 6.6 apps using UT assert. Effort needs to be made to figure out what unit test looks like for ECI 6.6 and document it accordingly.

@BaldBeacon BaldBeacon added the enhancement New feature or request label Aug 6, 2019
@SpaceSteve121
Copy link
Contributor

@BaldBeacon Should this be an issue for the CFS repo? I think its beyond the scope of ECI to define and/or document how to do unit testing in CFS 6.6.

Obviously we want access to that information, which is why I think we should probably open an issue on their repo and ask them to provide it.

@BaldBeacon
Copy link
Contributor Author

I've opened nasa/cFS#4 on the cFS repository to address this but ultimately we need to propagate those changes to the ECI (via documentation). I expect we should have some section explaining extra steps (if any) to get UT tests working with ECI apps, hence the separate issue.

@SpaceSteve121
Copy link
Contributor

Ok, after that additional bit of explanation I think we're on the same page, I just think the title of this issue is overly broad. I don't think that its ECI's responsibility to document CFE 6.6's UT system in general, which is what the issue title is proposing.

I'd propose changing the title of this issue to Build and run existing ECI unit tests under CFE6.6 and we'll make sure to note any steps which need to be taken (beyond the documentation CFS eventually provides) to run tests for apps based on ECI.

@BaldBeacon BaldBeacon changed the title Document how to add unit tests to an app in cFE 6.6 Build and run existing ECI unit tests under CFE 6.6 Aug 6, 2019
@BaldBeacon
Copy link
Contributor Author

I can agree with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants