Fix #95, Standardize command responses #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbaker
approved these changes
Nov 27, 2024
|
Thanks @thnkslprpt for these contributions! I'd like to get our team to review this one next week; would you be able to resolve the conflicts? |
thnkslprpt
force-pushed
the
fix-95-standardize-command-responses
branch
from
4442ca6 to
3860201
Compare
All done @dzbaker |
dzbaker
reviewed
Dec 5, 2024
| * | ||
| * \par Cause: | ||
| * | ||
| * This event message is issued when CS successfully disables an entry (specified | ||
| * by name) in the Memory results table but identifies the corresponding entry in | ||
| * the definitions table to be set to #CS_STATE_EMPTY. | ||
| */ | ||
| #define CS_DISABLE_MEMORY_DEF_EMPTY_DBG_EID 133 | ||
| #define CS_DISABLE_MEMORY_DEF_EMPTY_ERR_EID 133 |
There was a problem hiding this comment.
Why was this changed to error, as opposed to info? There were a good handful of others that were also changed to error and I'm not sure why?
There was a problem hiding this comment.
It's been a while mate, but I think it was just based on the issue description which specifically listed those as not complying with the current standard as debug and should be considered an ERROR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
Event types are standardized as per the issue description.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt